Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Veri*factu invoice and new layout for displaying QRs at the top #21

Merged
merged 9 commits into from
Dec 17, 2024
Merged

Add Veri*factu invoice and new layout for displaying QRs at the top #21

merged 9 commits into from
Dec 17, 2024

Conversation

beliolfa
Copy link
Contributor

No description provided.

@beliolfa beliolfa requested a review from samlown November 27, 2024 16:27
@beliolfa beliolfa marked this pull request as draft November 27, 2024 16:33
samlown
samlown requested changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@samlown samlown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some of the method and class names can be clearer, but otherwise looking good!

components/regimes/es/ticketbai.templ Outdated Show resolved Hide resolved
components/regimes/es/verifactu.templ Outdated Show resolved Hide resolved
components/bill/invoice/invoice.templ Outdated Show resolved Hide resolved
components/bill/invoice/helpers.go Outdated Show resolved Hide resolved
@beliolfa beliolfa requested a review from samlown December 13, 2024 11:10
@beliolfa beliolfa marked this pull request as ready for review December 13, 2024 11:10
samlown
samlown approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@samlown samlown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔝

@samlown samlown merged commit 961f55e into main Dec 17, 2024
4 checks passed
@samlown samlown deleted the verifactu_invoice branch December 17, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlown samlown samlown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beliolfa @samlown